AHeise commented on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-964912356
Hi @syhily , thanks for the fix. I was a bit lost in the initial discussions but the fix definitively looks good. The only change that I'd request is to merge both commits into one as they are the same logical entity: You'd usually write a test to showcase the issue and then turn it green with a fix. Since we don't want a commit that fails, we merge them both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
