akalash commented on a change in pull request #17737:
URL: https://github.com/apache/flink/pull/17737#discussion_r746488095
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/throughput/BufferDebloater.java
##########
@@ -83,6 +81,20 @@ public OptionalInt recalculateBufferSize(long
currentThroughput, int buffersInUs
return OptionalInt.of(newSize);
}
+ @VisibleForTesting
+ boolean skipUpdate(int newSize) {
+ if (newSize == lastBufferSize) {
+ return true;
+ }
+
+ if (newSize <= minBufferSize || newSize >= maxBufferSize) {
Review comment:
Yes, it is true. According to the logic in
`BufferDebloater#recalculateBufferSize`, the newSize can not be less than min
size and greater than max size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
