SteNicholas edited a comment on pull request #17691: URL: https://github.com/apache/flink/pull/17691#issuecomment-965101493
@slinkydeveloper @Airblader , thanks for the detailed review. I have addressed the above comments. But the tests for `CHR`, `REVERSE`, `SPLIT_INDEX`, `PARSE_URL`, `FROM_UNIXTIME` and `DECODE` couldn't add to `StringFunctionsITCase` which is tested for the `BuiltInFunctionDefinition` not `SqlFunction`. What's more, the original tests have tested some functions and they have been updated like `testJoinTemporalTable.out`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
