[ 
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360835#comment-15360835
 ] 

ASF GitHub Bot commented on FLINK-3034:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1813#discussion_r69408867
  
    --- Diff: 
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
 ---
    @@ -0,0 +1,193 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.redis;
    +
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.streaming.api.functions.sink.RichSinkFunction;
    +import 
org.apache.flink.streaming.connectors.redis.common.config.FlinkJedisClusterConfig;
    +import 
org.apache.flink.streaming.connectors.redis.common.config.FlinkJedisConfigBase;
    +import 
org.apache.flink.streaming.connectors.redis.common.config.FlinkJedisPoolConfig;
    +import 
org.apache.flink.streaming.connectors.redis.common.config.FlinkJedisSentinelConfig;
    +import 
org.apache.flink.streaming.connectors.redis.common.container.RedisCommandsContainer;
    +import 
org.apache.flink.streaming.connectors.redis.common.container.RedisCommandsContainerBuilder;
    +import 
org.apache.flink.streaming.connectors.redis.common.mapper.RedisCommand;
    +import 
org.apache.flink.streaming.connectors.redis.common.mapper.RedisDataType;
    +import 
org.apache.flink.streaming.connectors.redis.common.mapper.RedisCommandDescription;
    +import 
org.apache.flink.streaming.connectors.redis.common.mapper.RedisMapper;
    +
    +import org.apache.flink.util.Preconditions;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.IOException;
    +
    +/**
    + * A sink that delivers data to a Redis channel using the Jedis client.
    + * <p> The sink takes two arguments {@link FlinkJedisConfigBase} and 
{@link RedisMapper}.
    + * <p> When {@link FlinkJedisPoolConfig} is passed as the first argument,
    + * the sink will create connection using {@link 
redis.clients.jedis.JedisPool}. Please use this when
    + * you want to connect to a single Redis server.
    + * <p> When {@link FlinkJedisSentinelConfig} is passed as the first 
argument, the sink will create connection
    + * using {@link redis.clients.jedis.JedisSentinelPool}. Please use this 
when you want to connect to Sentinel.
    + * <p> Please use {@link FlinkJedisClusterConfig} as the first argument if 
you want to connect to
    + * a Redis Cluster.
    + *
    + * <p>Example:
    + *
    + * <pre>
    + *{@code
    + *public static class RedisExampleMapper implements 
RedisMapper<Tuple2<String, String>> {
    + *
    + * private RedisCommand redisCommand;
    + *
    + * public RedisAdditionalDataMapper(RedisCommand redisCommand){
    + *         this.redisCommand = redisCommand;
    + * }
    --- End diff --
    
    Wrong constructor name in the example in the Javadoc?


> Redis SInk Connector
> --------------------
>
>                 Key: FLINK-3034
>                 URL: https://issues.apache.org/jira/browse/FLINK-3034
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming Connectors
>            Reporter: Matthias J. Sax
>            Assignee: Subhankar Biswas
>            Priority: Minor
>
> Flink does not provide a sink connector for Redis.
> See FLINK-3033



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to