ruanhang1993 commented on a change in pull request #17556: URL: https://github.com/apache/flink/pull/17556#discussion_r747507035
########## File path: flink-test-utils-parent/flink-test-utils-junit/src/test/java/org/apache/flink/testutils/junit/RetryOnExceptionExtensionTest.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.testutils.junit; + +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.TestTemplate; +import org.junit.jupiter.api.extension.ExtendWith; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +/** Tests for the RetryOnException annotation. */ +@ExtendWith(RetryExtension.class) +public class RetryOnExceptionExtensionTest { + + private static final int NUMBER_OF_RUNS = 3; + + private static int runsForSuccessfulTest = 0; + + private static int runsForTestWithMatchingException = 0; + + private static int runsForTestWithSubclassException = 0; + + private static int runsForPassAfterOneFailure = 0; + + @AfterAll + public static void verify() { + assertEquals(NUMBER_OF_RUNS + 1, runsForTestWithMatchingException); + assertEquals(NUMBER_OF_RUNS + 1, runsForTestWithSubclassException); + assertEquals(1, runsForSuccessfulTest); + assertEquals(2, runsForPassAfterOneFailure); + } + + @TestTemplate Review comment: The test annotated with both `@TestTemplate` and `@Test` will execute twice in the junit jupiter engine and junit vintage engine. The test in junit jupiter will fail because of lacking the `TestTemplateInvocationContextProvider`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
