rkhachatryan commented on a change in pull request #17387:
URL: https://github.com/apache/flink/pull/17387#discussion_r747552327
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerMetricGroup.java
##########
@@ -81,61 +79,33 @@ public String taskManagerId() {
// job groups
// ------------------------------------------------------------------------
- public TaskMetricGroup addTaskForJob(
- final JobID jobId,
- final String jobName,
- final JobVertexID jobVertexId,
- final ExecutionAttemptID executionAttemptId,
- final String taskName,
- final int subtaskIndex,
- final int attemptNumber) {
+ public TaskManagerJobMetricGroup getOrCreateTaskManagerJobMetricGroup(
Review comment:
Ok...though it looks like there isn't much consistency:)
```
// TaskMetricGroup
public InternalOperatorMetricGroup getOrAddOperator(String operatorName)
{
return getOrAddOperator(OperatorID.fromJobVertexID(vertexId),
operatorName);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
