RocMarshal commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-966724208


   > What are you trying to solve? Could you please fill out the PR form 
correctly? I understand what your are doing on technical side but I don't 
understand why it's necessary. The ticket is also not giving any context 
information whatsoever.
   > 
   > I'm also interested in the side-effects. If we remove events prematurely 
do we miss certain patterns? Are we trading memory for correctness here?
   > 
   > You also should supply a test for your change.
   
   @AHeise I'm very sorry for such hasty description for the jira ticket and 
the PR. I uploaded the jvm memory dump file analyze result in the ticket and 
added a comment. I'm much obliged to you for helping me looking into the  
significance of the ticket.
   And after the discussion result of the ticket , I'll make response in 
closing it or re-filling out the PR form to advance it for the PR.
   Thanks again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to