curcur commented on a change in pull request #17462:
URL: https://github.com/apache/flink/pull/17462#discussion_r747958349



##########
File path: 
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java
##########
@@ -600,8 +600,14 @@ private ChangelogSnapshotState completeRestore(
                                     System.currentTimeMillis(),
                                     streamFactory,
                                     CHECKPOINT_OPTIONS),
-                            // TODO: add metadata to log FLINK-23170.
-                            upTo));
+                            upTo);
+
+            // log metadata after materialization is triggered
+            keyValueStatesByName
+                    .values()
+                    .forEach(t -> ((AbstractChangelogState) 
t).resetMetaDataWritten());

Review comment:
       Can you be more explicit what is the difference between `forEach` and 
`for-loop` here?
   
   Why it is blocking?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to