CrynetLogistics commented on a change in pull request #17345:
URL: https://github.com/apache/flink/pull/17345#discussion_r748113727
##########
File path:
flink-connectors/flink-connector-aws-kinesis-data-streams/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/AwsV2UtilTest.java
##########
@@ -258,7 +263,12 @@ public void testCreateNettyHttpClientWithDefaults() {
AwsV2Util.createHttpClient(clientConfiguration, builder, new
Properties());
- verify(builder).build();
+ AttributeMap defaultCustomAttribute =
Review comment:
I changed that method to `buildWithDefault` with a custom attribute
rather than `build`. This change relates to allowing users to set cert
checking. This attribute instead of being set in the builder, is set when
`buildWithDefault` is called, with an `AttributeMap` as parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
