[
https://issues.apache.org/jira/browse/FLINK-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361153#comment-15361153
]
ASF GitHub Bot commented on FLINK-4123:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2183
I have one final remark concerning the busy wait loop. I think it's better
to replace it with a wait-notify construct. Maybe we could also add a test
which assures that the `sendValues` loop is left in case of an exception.
After addressing this comment, I think the PR is good to be merged.
> CassandraWriteAheadSink can hang on cassandra failure
> -----------------------------------------------------
>
> Key: FLINK-4123
> URL: https://issues.apache.org/jira/browse/FLINK-4123
> Project: Flink
> Issue Type: Bug
> Components: Cassandra Connector
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.1.0
>
>
> The CassandraWriteAheadSink verifies that all writes send to cassandra have
> been applied by counting how many were sent and how many callbacks were
> activated. Once all writes were sent the sink enters into a loop that is only
> exited once both counts are equal.
> Thus, should cassandra crash after all writes were sent, without having
> acknowledged all writes, the sink will deadlock in the loop.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
