slinkydeveloper commented on a change in pull request #17739:
URL: https://github.com/apache/flink/pull/17739#discussion_r748304594
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableResultView.java
##########
@@ -309,12 +305,7 @@ private void updatePage() {
// convert page
final List<String[]> stringRows =
rows.stream()
- .map(
- r ->
- PrintUtils.rowToString(
- r,
-
resultDescriptor.getResultSchema(),
- sessionTimeZone))
+
.map(resultDescriptor.getRowDataStringConverter()::toString)
Review comment:
How about just `convert`? argument type and return types already make
very clear what the function does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
