curcur edited a comment on pull request #17462:
URL: https://github.com/apache/flink/pull/17462#issuecomment-968497357


   @rkhachatryan , Let's sync up offline?
   
   To answer the question above:
   1. Why is the test single thread? Because the materialization is triggered 
manually from the main thread, the mailbox executor is sycn mailbox and async 
pool is a direct executor. Now everything is executed in a single thread. This 
is easier to reason about for a unit test. I am writing a ITTest as well. So 
multi-thread will be tested as well.
   
   2. For test, I mean `ChangelogDelegateHashMapTest.testMaterializedRestore`. 
You can compare against what has been changed on this test. As explained 
previously, now it includes both changelog + materiliazation part.
   
   If you still have questions, let's sync up offline.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to