[
https://issues.apache.org/jira/browse/FLINK-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15361458#comment-15361458
]
Stephan Ewen commented on FLINK-4034:
-------------------------------------
I think that in general, enforcing dependency convergence is a great idea.
If we have divergence, it is a problem anyways, because we end up pulling
"some" version, without selecting a proper one. Making sure that everything is
converged means we are forced to explicitly solve all points where different
projects pull different versions. We should do that.
I saw you already opened a very big pull request. Can we actually take this one
component at a time (or few components at a time)? That will make it much
easier to review and decide.
Also, there is a big pull request that should solve some of this already by
simply cleaning up dependencies a bit: https://github.com/apache/flink/pull/2148
> Dependency convergence on com.101tec:zkclient and
> com.esotericsoftware.kryo:kryo
> --------------------------------------------------------------------------------
>
> Key: FLINK-4034
> URL: https://issues.apache.org/jira/browse/FLINK-4034
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.0.3
> Reporter: Vladislav Pernin
>
> If dependency convergence is enabled and asserted on Maven, projects using
> Flink do not compile.
> Example :
> {code}
> Dependency convergence error for com.esotericsoftware.kryo:kryo:2.24.0 paths
> to dependency are:
> +-groupidXXX:artifactidXXX:versionXXX
> +-org.apache.flink:flink-java:1.0.3
> +-org.apache.flink:flink-core:1.0.3
> +-com.esotericsoftware.kryo:kryo:2.24.0
> and
> +-groupidXXX:artifactidXXX:versionXXX
> +-org.apache.flink:flink-streaming-java_2.11:1.0.3
> +-org.apache.flink:flink-runtime_2.11:1.0.3
> +-com.twitter:chill_2.11:0.7.4
> +-com.twitter:chill-java:0.7.4
> +-com.esotericsoftware.kryo:kryo:2.21
> and
> +-groupidXXX:artifactidXXX:versionXXX
> +-org.apache.flink:flink-streaming-java_2.11:1.0.3
> +-org.apache.flink:flink-runtime_2.11:1.0.3
> +-com.twitter:chill_2.11:0.7.4
> +-com.esotericsoftware.kryo:kryo:2.21
> {code}
>
> {code}
> Dependency convergence error for com.101tec:zkclient:0.7 paths to dependency
> are:
> +-groupidXXX:artifactidXXX:versionXXX
> +-org.apache.flink:flink-connector-kafka-0.8_2.11:1.0.3
> +-org.apache.flink:flink-connector-kafka-base_2.11:1.0.3
> +-com.101tec:zkclient:0.7
> and
> +-groupidXXX:artifactidXXX:versionXXX
> +-org.apache.flink:flink-connector-kafka-0.8_2.11:1.0.3
> +-org.apache.kafka:kafka_2.11:0.8.2.2
> +-com.101tec:zkclient:0.3
> {code}
> I cannot emit a pull request without knowing on which specifics versions you
> rely.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)