dannycranmer commented on a change in pull request #17345:
URL: https://github.com/apache/flink/pull/17345#discussion_r749468520
##########
File path:
flink-connectors/flink-connector-aws-kinesis-data-streams/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java
##########
@@ -18,23 +18,21 @@
package org.apache.flink.streaming.connectors.kinesis.config;
import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.streaming.connectors.kinesis.FlinkKinesisConsumer;
-import org.apache.flink.streaming.connectors.kinesis.internals.ShardConsumer;
import
org.apache.flink.streaming.connectors.kinesis.model.SentinelSequenceNumber;
-import com.amazonaws.services.kinesis.model.ShardIteratorType;
+import software.amazon.awssdk.http.Protocol;
import java.time.Duration;
/**
- * Optional consumer specific configuration keys and default values for {@link
+ * Optional consumer specific configuration keys and default values for {@code
* FlinkKinesisConsumer}.
*/
@PublicEvolving
public class ConsumerConfigConstants extends AWSConfigConstants {
Review comment:
> This class is used by AwsV2Util which is used by the new features
It should not be, since this class is `ConsumerConfigConstants` and your new
feature is Producer. Both sequence number classes are also consumer concerns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
