wenlong88 commented on a change in pull request #17754:
URL: https://github.com/apache/flink/pull/17754#discussion_r749837647
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java
##########
@@ -146,10 +148,12 @@ public void eval(Object... keys) {
if (cache != null) {
List<RowData> cachedRows = cache.getIfPresent(keyRow);
if (cachedRows != null) {
- for (RowData cachedRow : cachedRows) {
- collect(cachedRow);
+ if (!cachedRows.isEmpty() || !excludeEmptyQueryResult) {
+ for (RowData cachedRow : cachedRows) {
Review comment:
you should verify that the empty value is not in the cache, will not
affect other eval. for example, eval for the time with empty result, update the
db, eval another time, the second eval could get the latest result .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
