gaoyunhaii commented on a change in pull request #33:
URL: https://github.com/apache/flink-ml/pull/33#discussion_r749864954
##########
File path: flink-ml-api/src/main/java/org/apache/flink/ml/api/core/Stage.java
##########
@@ -39,6 +39,7 @@
void save(String path) throws IOException;
// NOTE: every Stage subclass should implement a static method with
signature "static T
- // load(String path)", where T refers to the concrete subclass. This
static method should
- // instantiate a new stage instance based on the data from the given path.
+ // load(StreamExecutionEnvironment env, String path)", where T refers to
the concrete
Review comment:
We might move this part of comment to the class comments? Then it would
also appear in the java doc.
Also change `static T load(StreamExecutionEnvironment env, String path)` ->
`{@code static T load(StreamExecutionEnvironment env, String path)}` and `T` ->
`{@code T}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
