beyond1920 commented on a change in pull request #17733: URL: https://github.com/apache/flink/pull/17733#discussion_r749961611
########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/IntervalJoinUtil.scala ########## @@ -450,15 +452,26 @@ object IntervalJoinUtil { * else false. */ def satisfyIntervalJoin(join: FlinkLogicalJoin): Boolean = { + satisfyIntervalJoin(join, join.getLeft, join.getRight) Review comment: If no new left node and right node, there is no need to pass the original left and right again because we could get left/right from join node. It's a shortcut, besides, does not introduce unnessassary change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org