[
https://issues.apache.org/jira/browse/FLINK-24864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roman Khachatryan resolved FLINK-24864.
---------------------------------------
Release Note: TM-per-job metrics are now released upon last slot release
rather than task, i.e. may stay on TM longer.
Resolution: Fixed
Merged as f849ef304088f2fec15c433c2077b7a7e53ab890 into master.
> Release TaskManagerJobMetricGroup with the last slot rather than task
> ---------------------------------------------------------------------
>
> Key: FLINK-24864
> URL: https://issues.apache.org/jira/browse/FLINK-24864
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Metrics, Runtime / State Backends
> Reporter: Roman Khachatryan
> Assignee: Roman Khachatryan
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> // Beware that this ticket FLINK-24864 clones FLINK-23486.
>
> FLINK-23486 adds metrics for Changelog Uploader.
> Since that uploader is shared among tasks of the same job on a TM, the right
> level for metrics is TaskManagerJobMetricGroup (see [design
> doc|https://docs.google.com/document/d/1k5WkWIYzs3n3GYQC76H9BLGxvN3wuq7qUHJuBPR9YX0/edit?usp=sharing]).
>
> However, the lifecycle of TaskManagerJobMetricGroup differs from that of
> StateChangelogStorage: the former is released on last task unregister; the
> latter - on last job slot release.
> This causes problem that an old TMJMG can be used by Storage.
>
> Releasing Storage on last task unregister has some disadvantages, including
> overhead, thread-safety and logical inconsistency.
> Releasing TMJMG on last slot release doesn't have major disadvantages.
> This ticket proposes the former change.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
