snuyanzin commented on a change in pull request #17786:
URL: https://github.com/apache/flink/pull/17786#discussion_r750069955



##########
File path: 
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/MapAndMultisetToStringCastRule.java
##########
@@ -107,6 +120,28 @@ protected String generateCodeBlockInternal(
         final String keyArrayTerm = newName("keys");
         final String valueArrayTerm = newName("values");
 
+        return generateMapToString(

Review comment:
       yes, since we've decided to go with only class both for map and multiset 
this extraction does not make sense.
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to