nicoweidner commented on a change in pull request #17762:
URL: https://github.com/apache/flink/pull/17762#discussion_r750134764
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/application/ApplicationDispatcherBootstrap.java
##########
@@ -165,7 +170,9 @@ public void stop() {
if (applicationStatus ==
ApplicationStatus.CANCELED
|| applicationStatus ==
ApplicationStatus.FAILED) {
LOG.info("Application {}: ",
applicationStatus, t);
- return
dispatcherGateway.shutDownCluster(applicationStatus);
+ return shouldShutDownOnFinish
+ ?
dispatcherGateway.shutDownCluster(applicationStatus)
+ :
CompletableFuture.completedFuture(Acknowledge.get());
}
}
Review comment:
I added a comment stating that we do not prevent shutdown in that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
