slinkydeveloper commented on pull request #17800: URL: https://github.com/apache/flink/pull/17800#issuecomment-970229004
@snuyanzin Updated with feedback. The issue with date/time methods in particular is that the parsing methods from `DateTimeUtils` should fail, instead or returning boxed null values, and they should fail with proper exceptions explaining why. I want to avoid to tackle this particular aspect of the issue in this PR, since these methods are used in other parts of the codegen. I hope to fix once for all the behavior of these methods in the context of https://issues.apache.org/jira/browse/FLINK-24507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
