Airblader commented on a change in pull request #17808:
URL: https://github.com/apache/flink/pull/17808#discussion_r750483455
##########
File path:
flink-runtime-web/web-dashboard/src/app/share/common/dagre/svg-container.component.ts
##########
@@ -94,12 +86,12 @@ export class SvgContainerComponent implements OnInit,
AfterContentInit {
this.transform = `translate(${this.containerTransform.x}
,${this.containerTransform.y})scale(${this.containerTransform.k})`;
}
this.zoomEvent.emit(this.zoom);
- this.transformEvent.emit(this.containerTransform as SafeAny);
+ this.transformEvent.emit((this.containerTransform as unknown) as { x:
number; y: number; scale: number });
Review comment:
Yes, so there is some really weird type mismatch going on between `k`
and `scale` being used. You cannot type-assert this directly, the compiler
won't let you because there is not enough overlap for that to ever work. The
trick to assert it to `unknown` first is recommended by the compiler itself.
This is definitely a symptom of something being broken, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
