Airblader commented on a change in pull request #17811:
URL: https://github.com/apache/flink/pull/17811#discussion_r750651323
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -121,6 +121,27 @@
+ "into NOT NULL columns. Users can change
the behavior to 'drop' to "
+ "silently drop such records without
throwing exception.");
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<CharPrecisionEnforcer>
+ TABLE_EXEC_SINK_CHAR_PRECISION_ENFORCER =
+ key("table.exec.sink.char-precision-enforcer")
+ .enumType(CharPrecisionEnforcer.class)
+ .defaultValue(CharPrecisionEnforcer.ERROR.ERROR)
+ .withDescription(
Review comment:
Please don't list enum values, their explanation, or the default value
in the description; rather, document the enum values (implementing
`DescribedEnum`). The docs generator can then do a better job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
