wangyang0918 commented on a change in pull request #17685:
URL: https://github.com/apache/flink/pull/17685#discussion_r750896105
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/parameters/KubernetesJobManagerParameters.java
##########
@@ -64,10 +63,15 @@ public KubernetesJobManagerParameters(
.getOptional(KubernetesConfigOptions.JOB_MANAGER_LABELS)
.orElse(Collections.emptyMap()));
labels.putAll(getCommonLabels());
Review comment:
Currently, the selector has already contained the common labels. So I do
not think `user label + common label + selector` makes sense to me.
BTW, `KubernetesTaskManagerParameters#getLabels` has different semantic.
`Labels = user label + selector(internal labels)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
