[ 
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362469#comment-15362469
 ] 

ASF GitHub Bot commented on FLINK-4133:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2198#discussion_r69560211
  
    --- Diff: docs/apis/streaming/index.md ---
    @@ -1357,20 +1364,27 @@ Custom:
     
     <br />
     
    -Sources can by created by using 
`StreamExecutionEnvironment.addSource(sourceFunction)`.
    -You can either use one of the source functions that come with Flink or 
write a custom source
    -by implementing the `SourceFunction` for non-parallel sources, or by 
implementing the
    -`ParallelSourceFunction` interface or extending 
`RichParallelSourceFunction` for parallel sources.
    +Sources are where your program reads its input from. You can attach a 
source to your program by 
    +using `StreamExecutionEnvironment.addSource(sourceFunction)`. Flink comes 
with a number of pre-implemented 
    +source functions, but you can always write your own custom sources by 
implementing the `SourceFunction` 
    +for non-parallel sources, or by implementing the `ParallelSourceFunction` 
interface or extending the 
    +`RichParallelSourceFunction` for parallel sources.
     
     There are several predefined stream sources accessible from the 
`StreamExecutionEnvironment`:
     
     File-based:
     
    -- `readTextFile(path)` / `TextInputFormat` - Reads files line wise and 
returns them as Strings.
    --- End diff --
    
    It seems that the Java / Scala variants of the documentation are the same. 
I think we should remove the tab and show it once.


> Reflect streaming file source changes in documentation
> ------------------------------------------------------
>
>                 Key: FLINK-4133
>                 URL: https://issues.apache.org/jira/browse/FLINK-4133
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API, Documentation
>            Reporter: Robert Metzger
>            Assignee: Kostas Kloudas
>
> In FLINK-2314 the file sources for the DataStream API were reworked.
> The documentation doesn't explain the (new?) semantics of the file sources.
> In which order are files read?
> How are file modifications treated? (appends, in place modifications?)
> I suspect this table is also not up-to-date: 
> https://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/fault_tolerance.html#fault-tolerance-guarantees-of-data-sources-and-sinks
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to