lindong28 commented on pull request #24: URL: https://github.com/apache/flink-ml/pull/24#issuecomment-972499228
Thanks for the update @weibozhao. Here are some PR review convention that might be useful to make the review easier: - Maybe change the PR title and the commit message to follow the style of other Flink PRs. For example, `[FLINK-24557] Support Knn in Flink ML`. Even better, maybe we can use the same message as other algorithm PRs, e.g. `[FLINK-24557] Add KNN classification algorithm`. -Can you resolve the comments that you have addressed on this Github page? This allows us to see which comments need further discussion? - Can you clean up commit message in such a way that those commits can be merged as is? The PR currently contains commit messages such as `refine knn code format` which is probably not necessary. Please feel free to follow commit messages in the existing Flink repository for example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
