lindong28 commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r752285170
########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/params/shared/colname/HasOutputColDefaultAsNull.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.ml.params.shared.colname; + +import org.apache.flink.ml.param.Param; +import org.apache.flink.ml.param.StringParam; +import org.apache.flink.ml.param.WithParams; + +/** + * An interface for classes with a parameter specifying name of the output column with a null + * default value. + * + * @see HasOutputCol + * @see HasOutputCols + * @see HasOutputColsDefaultAsNull + */ +public interface HasOutputColDefaultAsNull<T> extends WithParams<T> { Review comment: Can we just use `HasOutputCol` without adding `HasOutputColDefaultAsNull`? Same for other parameters with similar patterns. ########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/params/shared/colname/HasPredictionDetailCol.java ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.ml.params.shared.colname; + +import org.apache.flink.ml.param.Param; +import org.apache.flink.ml.param.ParamValidators; +import org.apache.flink.ml.param.StringParam; +import org.apache.flink.ml.param.WithParams; + +/** + * An interface for classes with a parameter specifying the column name of prediction detail. + * + * <p>The detail is the information of prediction result, such as the probability of each label in + * classifier. + */ +public interface HasPredictionDetailCol<T> extends WithParams<T> { Review comment: Maybe remove this for now? ########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/params/shared/colname/HasPredictionCol.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.ml.params.shared.colname; + +import org.apache.flink.ml.param.Param; +import org.apache.flink.ml.param.ParamValidators; +import org.apache.flink.ml.param.StringParam; +import org.apache.flink.ml.param.WithParams; + +/** An interface for classes with a parameter specifying the column name of the prediction. */ +public interface HasPredictionCol<T> extends WithParams<T> { Review comment: Can we re-use the existing `org.apache.flink.ml.common.param.HasPredictionCol`? ########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/distance/EuclideanDistance.java ########## @@ -0,0 +1,259 @@ +package org.apache.flink.ml.classification.knn.distance; + +import org.apache.flink.ml.common.linalg.BLAS; +import org.apache.flink.ml.common.linalg.DenseMatrix; +import org.apache.flink.ml.common.linalg.DenseVector; +import org.apache.flink.ml.common.linalg.MatVecOp; +import org.apache.flink.ml.common.linalg.SparseVector; +import org.apache.flink.ml.common.linalg.Vector; +import org.apache.flink.util.Preconditions; + +import java.util.Arrays; + +/** + * Euclidean distance is the "ordinary" straight-line distance between two points in Euclidean + * space. + * + * <p>https://en.wikipedia.org/wiki/Euclidean_distance + * + * <p>Given two vectors a and b, Euclidean Distance = ||a - b||, where ||*|| means the L2 norm of + * the vector. + */ +public class EuclideanDistance extends BaseFastDistance { Review comment: Has the PR been updated with the latest change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
