weibozhao commented on a change in pull request #24:
URL: https://github.com/apache/flink-ml/pull/24#discussion_r752851858



##########
File path: flink-ml-api/src/main/java/org/apache/flink/ml/linalg/Vector.java
##########
@@ -29,6 +29,10 @@
     /** Gets the value of the ith element. */
     double get(int i);
 
+
+    /** set the value of the ith element. */
+    void set(int i, double val);

Review comment:
       In some case, we just want to update the vector, we use sample to update 
special value. if use vector new, it may allocate a new memory, it not always 
the good thing.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to