Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1954#discussion_r69697772
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FailureRateRestartStrategy.java
---
@@ -35,19 +34,21 @@
* with a fixed time delay in between.
*/
public class FailureRateRestartStrategy implements RestartStrategy {
- private final int maxFailuresPerUnit;
- private final TimeUnit failureRateUnit;
- private final long delayBetweenRestartAttempts;
- private List<Long> restartTimestamps = new ArrayList<>();
+ private final Duration failuresInterval;
+ private final Duration delayInterval;
+ private EvictingQueue<Long> restartTimestampsQueue;
--- End diff --
Can we replace `EvictingQueue` with an `ArrayDequeue`? It gives you almost
the same features as the `EvictingQueue` with similar performance and we would
not introduce a further dependency on Guava. The reason is that we gradually
try to get rid of Guava because different versions of Guava are not fully
compatible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
