pnowojski commented on a change in pull request #41:
URL: https://github.com/apache/flink-benchmarks/pull/41#discussion_r754410945
##########
File path: README.md
##########
@@ -31,14 +31,33 @@ There're mainly two ways:
mvn -Dflink.version=<FLINK_VERSION> clean package exec:exec \
-Dbenchmarks="<benchmark_class>"
```
-An example flink version can be -Dflink.version=1.12-SNAPSHOT.
+
+ An example flink version can be -Dflink.version=1.12-SNAPSHOT.
+
+3. Run the uber jar directly like:
+
+ ```
+ java -jar target/benchmarks.jar -rf csv "<benchmark_class>"
+ ```
We also support to run each benchmark once (with only one fork and one
iteration) for testing, with below command:
```
mvn test -P test
```
+## Params
Review comment:
nit: (here and in other places) `params` -> `parameters`
##########
File path:
src/main/java/org/apache/flink/state/benchmark/StateBenchmarkBase.java
##########
@@ -52,10 +56,21 @@
final ThreadLocalRandom random = ThreadLocalRandom.current();
@Param({"HEAP", "ROCKSDB"})
- protected StateBackendBenchmarkUtils.StateBackendType backendType;
+ private StateBackendBenchmarkUtils.StateBackendType backendType;
+
+ @Param({"/tmp"})
Review comment:
Will this be behaving in the same/similar way as it used to be? What if
on the given machine there is no `/tmp` directory or the JVM process doesn't
have an access to it? I think the old `null` value was more resilient?
##########
File path: README.md
##########
@@ -31,14 +31,33 @@ There're mainly two ways:
mvn -Dflink.version=<FLINK_VERSION> clean package exec:exec \
Review comment:
nitty nit: In line 24 replace:
> There're mainly two way
with
> There're three ways
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
