[
https://issues.apache.org/jira/browse/FLINK-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365910#comment-15365910
]
ASF GitHub Bot commented on FLINK-4167:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2210
Calling close() isn't necessary since no metric should ever be registered
directly on the IOMetricGroup. This group is supposed to only contain
pre-defined metrics that can be accessed from multiple places. These metrics
are registered on the TaskMetricGroup, and thus cleaned up.
A proper fix would be to override the addMetric() method to throw an
exception when that is done, or to refer registration to the TaskMetricGroup.
Addendum for clarification: TaskMetrics aren't technically cleaned up at
the end of the job, but when no task for a given job runs on a TM.
Given the current usage of the IOMetricGroup i sincerely doubt that is
caused an actual issue, and thus would like you provide more information on the
issue you faced.
> TaskMetricGroup does not close IOMetricGroup
> --------------------------------------------
>
> Key: FLINK-4167
> URL: https://issues.apache.org/jira/browse/FLINK-4167
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> The {{TaskMetricGroup}} does not close the {{ioMetrics}} metric group. This
> causes that metrics registered under the {{ioMetrics}} are not deregistered
> after the termination of a job.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
