akalash commented on a change in pull request #17660:
URL: https://github.com/apache/flink/pull/17660#discussion_r755006636
##########
File path: docs/content.zh/docs/ops/metrics.md
##########
@@ -916,12 +916,17 @@ Metrics related to data exchange between task executors
using netty network comm
<td>Gauge</td>
</tr>
<tr>
- <th rowspan="18">Task</th>
- <td rowspan="4">Shuffle.Netty.Input.Buffers</td>
+ <th rowspan="20">Task</th>
+ <td rowspan="5">Shuffle.Netty.Input.Buffers</td>
<td>inputQueueLength</td>
<td>The number of queued input buffers.</td>
<td>Gauge</td>
</tr>
+ <tr>
+ <td>inputQueueSize</td>
+ <td>The real size of queued input buffers in bytes. The size for local
input channels is only estimated.</td>
Review comment:
In fact, you are right we count bytes twice for the local input channel
but we do the same thing for `outputQueueLength`/`inputQueueLength`. But maybe
it is not a bad idea to always return zero for local input channels since they
take the data directly from output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
