akalash commented on a change in pull request #17701:
URL: https://github.com/apache/flink/pull/17701#discussion_r755056468
##########
File path:
flink-core/src/main/java/org/apache/flink/core/fs/CloseableRegistry.java
##########
@@ -62,10 +67,13 @@ protected boolean doUnRegister(
return closeableMap.remove(closeable) != null;
}
+ /**
+ * This implementation doesn't imply any exception during closing due to
backward compatibility.
+ */
@Override
- protected Collection<Closeable> getReferencesToClose() {
- ArrayList<Closeable> closeablesToClose = new
ArrayList<>(closeableToRef.keySet());
- Collections.reverse(closeablesToClose);
- return closeablesToClose;
+ public void doClose(Collection<Closeable> toClose) throws IOException {
+ List<AutoCloseable> reversed = new ArrayList<>(toClose);
Review comment:
Yes, I can do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
