[
https://issues.apache.org/jira/browse/FLINK-24938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-24938:
-----------------------------------
Labels: pull-request-available (was: )
> Checkpoint cleaner is closed before checkpoints are discarded
> -------------------------------------------------------------
>
> Key: FLINK-24938
> URL: https://issues.apache.org/jira/browse/FLINK-24938
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
> Affects Versions: 1.14.0, 1.15.0
> Reporter: Roman Khachatryan
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.15.0, 1.14.1
>
>
> When CompletedCheckpointStore shuts down it tries to discard some checkpoints
> using CheckpointCleaner. The latter is closed asynchronously since
> FLINK-23647 and before the Store.
> Visible as warning when running
> ResumeCheckpointManuallyITCase.testExternalizedIncrementalRocksDBCheckpointsZookeeper:
> {code}
> 2021-11-17 10:47:10,599 Fail to remove checkpoint during shutdown.
> [DefaultCompletedCheckpointStore flink-akka.actor.default-dispatcher-5]
> java.lang.IllegalStateException: CheckpointsCleaner has already been closed
> at
> org.apache.flink.util.Preconditions.checkState(Preconditions.java:193)
> ~[classes/:?]
> at
> org.apache.flink.runtime.checkpoint.CheckpointsCleaner.incrementNumberOfCheckpointsToClean(CheckpointsCleaner.java:105)
> ~[classes/:?]
> at
> org.apache.flink.runtime.checkpoint.CheckpointsCleaner.cleanup(CheckpointsCleaner.java:87)
> ~[classes/:?]
> at
> org.apache.flink.runtime.checkpoint.CheckpointsCleaner.cleanCheckpoint(CheckpointsCleaner.java:62)
> ~[classes/:?]
> at
> org.apache.flink.runtime.checkpoint.DefaultCompletedCheckpointStore.tryRemoveCompletedCheckpoint(DefaultCompletedCheckpointStore.java:2
> at
> org.apache.flink.runtime.checkpoint.DefaultCompletedCheckpointStore.shutdown(DefaultCompletedCheckpointStore.java:172)
> ~[classes/:?]
> at
> org.apache.flink.runtime.scheduler.SchedulerBase.shutDownCheckpointServices(SchedulerBase.java:222)
> ~[classes/:?]
> {code}
> But the test still passes.
> cc: [~pnowojski]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
