[
https://issues.apache.org/jira/browse/FLINK-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366119#comment-15366119
]
ASF GitHub Bot commented on FLINK-4171:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2212#discussion_r69907899
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/AbstractReporter.java
---
@@ -74,4 +74,14 @@ public void notifyOfRemovedMetric(Metric metric, String
metricName, AbstractMetr
}
}
}
+
+ /**
+ * Can be overridden by sub-classes to replace invalid characters in
metric name.
+ *
+ * @param metricName Name of the metric
--- End diff --
or maybe not.
> StatsD does not accept metrics whose name contains ":"
> ------------------------------------------------------
>
> Key: FLINK-4171
> URL: https://issues.apache.org/jira/browse/FLINK-4171
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.1.0
>
>
> The {{StatsDReporter}} mustn't send metrics whose name contains a ":"
> character to {{StatsD}} because these reports are discarded. The reason is
> that ":" is used to separate the value from the metric name.
> I propose to check the metric names and replace all ":" by a "-" character.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
