[
https://issues.apache.org/jira/browse/FLINK-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366458#comment-15366458
]
ASF GitHub Bot commented on FLINK-3599:
---------------------------------------
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r69951075
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -315,6 +331,23 @@ public int getFieldIndex(String fieldName) {
reflectiveFields[i] = fields[i].getField();
}
+ if (customSerializers.containsKey(this.getTypeClass())) {
+ Constructor<?>[] ctors =
customSerializers.get(this.getTypeClass()).getConstructors();
+ assert ctors.length == 1;
+ try {
+ return (TypeSerializer<T>)
ctors[0].newInstance(new Object[]{getTypeClass(), fieldSerializers, config});
+
+ } catch (Throwable t) {
--- End diff --
Stephan noted to me a little while back that IntelliJ convention for an
unused exception is to name the variable `ignored`, so `} catch (Throwable
ignored) {`.
> GSoC: Code Generation in Serializers
> ------------------------------------
>
> Key: FLINK-3599
> URL: https://issues.apache.org/jira/browse/FLINK-3599
> Project: Flink
> Issue Type: Improvement
> Components: Type Serialization System
> Reporter: Márton Balassi
> Assignee: Gabor Horvath
> Labels: gsoc2016, mentor
>
> The current implementation of the serializers can be a
> performance bottleneck in some scenarios. These performance problems were
> also reported on the mailing list recently [1].
> E.g. the PojoSerializer uses reflection for accessing the fields, which is
> slow [2].
> For the complete proposal see [3].
> [1]
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Tuple-performance-and-the-curious-JIT-compiler-td10666.html
> [2]
> https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java#L369
> [3]
> https://docs.google.com/document/d/1VC8lCeErx9kI5lCMPiUn625PO0rxR-iKlVqtt3hkVnk
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
