Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r69952548
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +75,21 @@
private static final Pattern PATTERN_NESTED_FIELDS =
Pattern.compile(REGEX_NESTED_FIELDS);
private static final Pattern PATTERN_NESTED_FIELDS_WILDCARD =
Pattern.compile(REGEX_NESTED_FIELDS_WILDCARD);
+ private static final Map<Class<?>, Class<? extends TypeSerializer>>
customSerializers = new HashMap<>();
+ private static final Map<Class<?>, Class<? extends TypeComparator>>
customComparators = new HashMap<>();
+
private final PojoField[] fields;
private final int totalFields;
+ public static <C, S extends TypeSerializer<C>> void
registerCustomSerializer(Class<C> c, Class<S> s) {
+ customSerializers.put(c, s);
--- End diff --
Should we also do a preconditions check here (and in
`registerCustomComparator`) that `s` has a single public constructor? Is the
assertion message obvious in `createSerializer`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
