slinkydeveloper commented on a change in pull request #17898:
URL: https://github.com/apache/flink/pull/17898#discussion_r756241850
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/UnresolvedException.java
##########
@@ -18,7 +18,10 @@
package org.apache.flink.table.api;
+import org.apache.flink.annotation.PublicEvolving;
+
/** Exception for unwanted method calling on unresolved expression. */
+@PublicEvolving
public class UnresolvedException extends RuntimeException {
Review comment:
This exception is referenced only in one place in the planner, so
perhaps move it to the planner without marking it public evolving?
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/NoMatchingTableFactoryException.java
##########
@@ -28,6 +29,7 @@
import java.util.stream.Collectors;
/** Exception for not finding a {@link TableFactory} for the given properties.
*/
+@PublicEvolving
public class NoMatchingTableFactoryException extends RuntimeException {
Review comment:
I think this one should not be `PublicEvolving`, but perhaps we should
rather move it outside the `api` package as it's not referenced by any class in
this package, but only by internal classes `TableFactoryService` and
`FactoryUtil`. Also, the only reason for this class to be useful from the user
point of view is that it can be instance checked on, as the class itself is not
adding any method with more informations about the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
