cc13ny commented on a change in pull request #17554:
URL: https://github.com/apache/flink/pull/17554#discussion_r756310567
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java
##########
@@ -256,36 +244,51 @@ private String getWebMonitorAddress(Configuration
configuration) throws Exceptio
flinkConfig.get(JobManagerOptions.PORT));
}
+ final KubernetesJobManagerParameters kubernetesJobManagerParameters =
+ new KubernetesJobManagerParameters(flinkConfig,
clusterSpecification);
+
+ final FlinkPod podTemplate =
+ kubernetesJobManagerParameters
+ .getPodTemplateFilePath()
+ .map(
+ file ->
+
KubernetesUtils.loadPodFromTemplateFile(
+ client, file,
Constants.MAIN_CONTAINER_NAME))
+ .orElse(new FlinkPod.Builder().build());
+ final KubernetesJobManagerSpecification kubernetesJobManagerSpec =
+
KubernetesJobManagerFactory.buildKubernetesJobManagerSpecification(
+ podTemplate, kubernetesJobManagerParameters);
+
+ client.createJobManagerComponent(kubernetesJobManagerSpec);
+
+ return createClusterClientProvider(clusterId);
+ }
+
+ private ClusterClientProvider<String> safelyDeployCluster(
+ SupplierWithException<ClusterClientProvider<String>, Exception>
supplier)
+ throws ClusterDeploymentException {
try {
- final KubernetesJobManagerParameters
kubernetesJobManagerParameters =
- new KubernetesJobManagerParameters(flinkConfig,
clusterSpecification);
-
- final FlinkPod podTemplate =
- kubernetesJobManagerParameters
- .getPodTemplateFilePath()
- .map(
- file ->
-
KubernetesUtils.loadPodFromTemplateFile(
- client, file,
Constants.MAIN_CONTAINER_NAME))
- .orElse(new FlinkPod.Builder().build());
- final KubernetesJobManagerSpecification kubernetesJobManagerSpec =
-
KubernetesJobManagerFactory.buildKubernetesJobManagerSpecification(
- podTemplate, kubernetesJobManagerParameters);
-
- client.createJobManagerComponent(kubernetesJobManagerSpec);
-
- return createClusterClientProvider(clusterId);
+
+ ClusterClientProvider<String> clusterClientProvider =
supplier.get();
+
+ try (ClusterClient<String> clusterClient =
clusterClientProvider.getClusterClient()) {
Review comment:
> Because the Flink cluster might be running normally.
I think the same. It turns out to be, if cleaning up the K8s resources is
the best strategy or if it's possible to retry and re-create a client with the
existing resource? Cleaning up is definitely the simplest way. It depends on
how much and in which failing situations we would like to handle (e.g.
re-create the client).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
