nuno-c-afonso commented on a change in pull request #17345:
URL: https://github.com/apache/flink/pull/17345#discussion_r756791898
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyV2Factory.java
##########
@@ -47,22 +49,27 @@
public static KinesisProxyV2Interface createKinesisProxyV2(final
Properties configProps) {
Preconditions.checkNotNull(configProps);
- final ClientConfiguration clientConfiguration =
- new ClientConfigurationFactory().getConfig();
+ final AttributeMap convertedProperties =
AwsV2Util.convertProperties(configProps);
+ final AttributeMap.Builder clientConfiguration =
AttributeMap.builder();
populateDefaultValues(clientConfiguration);
Review comment:
`ClientConfiguration` fields have been split into `AttributeMap` (used
in the creation of the HTTP client) and `SdkClientConfiguration` (used in
`createKinesisAsyncClient`). `AwsV2Util.convertProperties` extracts the
properties that are used in the creation of the HTTP client -
`EFO_HTTP_CLIENT_MAX_CONCURRENCY` and `EFO_HTTP_CLIENT_READ_TIMEOUT_MILLIS` are
the only ones that need to be considered.
Regarding the defaults, the current implementation uses the [defaults from
`NettyNioAsyncHttpClient.Builder`](https://github.com/aws/aws-sdk-java-v2/blob/4b9e3cbaa071100bc160996741215e21cc3073a6/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.java#L722-L726).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
