tillrohrmann commented on a change in pull request #17607:
URL: https://github.com/apache/flink/pull/17607#discussion_r756909528
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
##########
@@ -87,18 +88,19 @@
private static final Logger LOG =
LoggerFactory.getLogger(ZooKeeperStateHandleStore.class);
- @VisibleForTesting
- static final Set<Class<? extends KeeperException>> PRE_COMMIT_EXCEPTIONS =
- newHashSet(
- KeeperException.NodeExistsException.class,
- KeeperException.BadArgumentsException.class,
- KeeperException.NoNodeException.class,
- KeeperException.NoAuthException.class,
- KeeperException.BadVersionException.class,
- KeeperException.AuthFailedException.class,
- KeeperException.InvalidACLException.class,
- KeeperException.SessionMovedException.class,
- KeeperException.NotReadOnlyException.class);
+ /** Pre-commit exceptions that don't imply data inconsistency. */
+ private static final Set<Class<? extends KeeperException>>
SAFE_PRE_COMMIT_EXCEPTIONS =
+ new HashSet<>(
+ Arrays.asList(
+ KeeperException.NodeExistsException.class,
+ KeeperException.BadArgumentsException.class,
+ KeeperException.NoNodeException.class,
+ KeeperException.NoAuthException.class,
+ KeeperException.BadVersionException.class,
+ KeeperException.AuthFailedException.class,
+ KeeperException.InvalidACLException.class,
+ KeeperException.SessionMovedException.class,
+ KeeperException.NotReadOnlyException.class));
Review comment:
Agreed.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
##########
@@ -87,18 +88,19 @@
private static final Logger LOG =
LoggerFactory.getLogger(ZooKeeperStateHandleStore.class);
- @VisibleForTesting
- static final Set<Class<? extends KeeperException>> PRE_COMMIT_EXCEPTIONS =
- newHashSet(
- KeeperException.NodeExistsException.class,
- KeeperException.BadArgumentsException.class,
- KeeperException.NoNodeException.class,
- KeeperException.NoAuthException.class,
- KeeperException.BadVersionException.class,
- KeeperException.AuthFailedException.class,
- KeeperException.InvalidACLException.class,
- KeeperException.SessionMovedException.class,
- KeeperException.NotReadOnlyException.class);
+ /** Pre-commit exceptions that don't imply data inconsistency. */
+ private static final Set<Class<? extends KeeperException>>
SAFE_PRE_COMMIT_EXCEPTIONS =
+ new HashSet<>(
+ Arrays.asList(
+ KeeperException.NodeExistsException.class,
Review comment:
Ok, let's tackle this with the follow-up issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
