CrynetLogistics commented on a change in pull request #17913:
URL: https://github.com/apache/flink/pull/17913#discussion_r756963448
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/AsyncSinkBaseBuilder.java
##########
@@ -40,8 +40,9 @@
private Integer maxBatchSize;
private Integer maxInFlightRequests;
private Integer maxBufferedRequests;
- private Long flushOnBufferSizeInBytes;
+ private Long maxBatchSizeInBytes;
private Long maxTimeInBufferMS;
+ private Long maxRecordSizeInBytes;
Review comment:
Yeah, they're nullable, so we can pull in defaults if null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
