[
https://issues.apache.org/jira/browse/FLINK-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-12298:
-----------------------------------
Labels: auto-deprioritized-major auto-deprioritized-minor (was:
auto-deprioritized-major stale-minor)
Priority: Not a Priority (was: Minor)
This issue was labeled "stale-minor" 7 days ago and has not received any
updates so it is being deprioritized. If this ticket is actually Minor, please
raise the priority and ask a committer to assign you the issue or revive the
public discussion.
> Make column functions accept custom Range class rather than Expression
> ----------------------------------------------------------------------
>
> Key: FLINK-12298
> URL: https://issues.apache.org/jira/browse/FLINK-12298
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / API
> Reporter: Dawid Wysakowicz
> Priority: Not a Priority
> Labels: auto-deprioritized-major, auto-deprioritized-minor
>
> I would suggest to rework the column functions to a more typesafe approach
> with custom {{Range}} class. Right now {{withColumns}} accepts array of
> Expressions. We have
> {{org.apache.flink.table.api.scala.ImplicitExpressionOperations#to}} method,
> but also we have implicit conversion from {{scala.Range}} to Expression
> range. This already introduces ambiguity, as it is unclear what will be the
> end product of expression like {{1 to 9}}. This approach defers the checking
> of the types of expressions to expressions resolution phase.
> I would suggest to make
> {{org.apache.flink.table.api.scala.withColumns#apply}} always accept e.g.
> {{ColumnRange}} that could always accept only {{Integer}} or {{String}}
> instead of Expressions. Such class could look like (this is just a very rough
> outline):
> {code}
> class ColumnRange {
> IndexRange idx(Integer idx);
> ReferenceRange ref(String reference);
> }
> class IndexRange {
> IndexRange to(Integer idx);
> }
> class ReferenceRange {
> ReferenceRange to(String ref);
> }
> {code}
> We could also have implicit conversion from {{scala.Range}} to {{IndexRange}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
