zhipeng93 commented on a change in pull request #30: URL: https://github.com/apache/flink-ml/pull/30#discussion_r757197847
########## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/common/datastream/AllReduceUtilsTest.java ########## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.common.datastream; + +import org.apache.flink.api.common.functions.FlatMapFunction; +import org.apache.flink.api.common.typeinfo.BasicTypeInfo; +import org.apache.flink.streaming.api.datastream.DataStream; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.streaming.api.functions.sink.SinkFunction; +import org.apache.flink.util.Collector; +import org.apache.flink.util.NumberSequenceIterator; + +import org.junit.Test; +import org.junit.experimental.runners.Enclosed; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +import java.util.Arrays; +import java.util.Collection; + +import static org.junit.Assert.assertEquals; + +/** Tests the {@link org.apache.flink.ml.common.datastream.AllReduceUtils}. */ +@RunWith(Enclosed.class) +public class AllReduceUtilsTest { + + private static final int parallelism = 4; + + /** Parameterized test for {@link org.apache.flink.ml.common.datastream.AllReduceUtils}. */ + @RunWith(Parameterized.class) + public static class ParameterizedTest { + private static int numElements; + + @Parameterized.Parameters + public static Collection<Object[]> params() { + return Arrays.asList(new Object[][] {{0}, {100}, {10000}, {100000}, {10000000}}); Review comment: Thanks for the comments. I have updated the PR. Please check out for AllReduceImplTest#L48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
