Zakelly commented on a change in pull request #17874:
URL: https://github.com/apache/flink/pull/17874#discussion_r757371208
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/DefaultConfigurableOptionsFactory.java
##########
@@ -65,7 +65,13 @@
* An implementation of {@link ConfigurableRocksDBOptionsFactory} using
options provided by {@link
* RocksDBConfigurableOptions}. It acts as the default options factory within
{@link
* EmbeddedRocksDBStateBackend} if the user did not define a {@link
RocksDBOptionsFactory}.
+ *
+ * <p>After FLINK-24046, we refactor the config procedure for RocksDB. User
could use {@link
+ * ConfigurableRocksDBOptionsFactory} to apply some customized options.
Besides this, we load the
+ * configurable options in {@link RocksDBResourceContainer} instead of {@link
+ * DefaultConfigurableOptionsFactory}. Thus, we mark this factory Deprecated.
*/
+@Deprecated
public class DefaultConfigurableOptionsFactory implements
ConfigurableRocksDBOptionsFactory {
Review comment:
Yeah, I removed the outdated tests and change some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
