slinkydeveloper commented on a change in pull request #17878:
URL: https://github.com/apache/flink/pull/17878#discussion_r758525589
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java
##########
@@ -59,8 +59,25 @@
import static java.time.temporal.ChronoField.YEAR;
/**
- * Utility functions for datetime types: date, time, timestamp. Currently, it
is a bit messy putting
- * date time functions in various classes because the runtime module does not
depend on calcite..
+ * Utility functions for datetime types: date, time, timestamp.
+ *
+ * <p>These utils include:
+ *
+ * <ul>
+ * <li>{@code parse[type]}: methods for parsing strings to
date/time/timestamp
+ * <li>{@code format[type]}: methods for formatting date/time/timestamp
+ * <li>{@code to[externalTypeName]} and {@code toInternal}: methods for
converting values from
+ * internal date/time/timestamp types from/to java.sql or java.time types
+ * <li>Various operations on timestamp, including floor, ceil and extract
+ * <li>{@link TimeUnit} and {@link TimeUnitRange} enums
+ * </ul>
+ *
+ * Currently, this class is a bit messy because it includes a mix of
functionalities both from
+ * common and planner. We should strive to reduce the number of
functionalities here, eventually
+ * moving some methods closer to where they're needed. Connectors nor formats
should not use this
Review comment:
Check now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
