twalthr commented on a change in pull request #17911:
URL: https://github.com/apache/flink/pull/17911#discussion_r759104642
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/CastRuleProvider.java
##########
@@ -203,6 +224,7 @@ private CastRuleProvider addRule(CastRule<?, ?> rule) {
/* lookup by any family matching */
for (LogicalTypeFamily family : type.getFamilies()) {
out = map.get(family);
+ // TODO what if multiple?
Review comment:
we should avoid TODOs to the code base, either we fix it or it is not an
issue currently
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala
##########
@@ -1096,29 +1096,6 @@ object ScalarOperatorGens {
operandTerm => s"$operandTerm.toBytes($serTerm)"
}
- // Note: SQL2003 $6.12 - casting is not allowed between boolean and
numeric types.
Review comment:
Is this comment worth to be preserved? I guess it is even wrong, because
Calcite allows certain numeric types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
