[
https://issues.apache.org/jira/browse/FLINK-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370252#comment-15370252
]
Tzu-Li (Gordon) Tai edited comment on FLINK-4170 at 7/11/16 6:36 AM:
---------------------------------------------------------------------
As part of this issue, I also propose to separate the consumer and producer
configs into two classes, {{ConsumerConfigConstants}} and
{{ProducerConfigConstants}}.
Right now the producer-specific config keys are prefixed with {{PRODUCER_}},
while the consumer-specific ones don't have a prefix. If we would add a
{{CONSUMER_}} prefix to them it would become too long again. I think it'd be
better off to separate them, also so that the config constants won't get
overwhelmed in the same class as we add more configs in the future.
was (Author: tzulitai):
As part of this issue, I also propose to separate the consumer and producer
configs into two classes, `ConsumerConfigConstants` and
`ProducerConfigConstants`.
Right now the producer-specific config keys are prefixed with `PRODUCER_`,
while the consumer-specific ones don't have a prefix. If we would add a
`CONSUMER_` prefix to them it would become too long again. I think it'd be
better off to separate them, also so that the config constants won't get
overwhelmed in the same class as we add more configs in the future.
> Remove `CONFIG_` prefix from KinesisConfigConstants variables
> -------------------------------------------------------------
>
> Key: FLINK-4170
> URL: https://issues.apache.org/jira/browse/FLINK-4170
> Project: Flink
> Issue Type: Improvement
> Components: Streaming Connectors
> Reporter: Ufuk Celebi
> Assignee: Tzu-Li (Gordon) Tai
> Fix For: 1.1.0
>
>
> I find the static variable names verbose. I think it's clear from context
> that they refer to the Kinesis configuration since they are all gathered in
> that class.
> Therefore would like to remove the {{CONFIG_}} prefix before the release, so
> that we have
> {code}
> conf.put(KinesisConfigConstants.AWS_REGION, "")
> {code}
> instead of
> {code}
> conf.put(KinesisConfigConstants.CONFIG_AWS_REGION, "")
> {code}
> For longer variables it becomes even longer otherwise.
> ---
> Some basic variable names that might be accessed frequently are also very
> long:
> {code}
> CONFIG_AWS_CREDENTIALS_PROVIDER_BASIC_SECRETKEY
> CONFIG_AWS_CREDENTIALS_PROVIDER_BASIC_ACCESSKEYID
> {code}
> It might suffice to just have:
> {code}
> AWS_SECRET_KEY
> AWS_ACCESS_KEY
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
