matriv commented on a change in pull request #17911: URL: https://github.com/apache/flink/pull/17911#discussion_r759987143
########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/BooleanToNumericCastRule.java ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.functions.casting; + +import org.apache.flink.table.types.logical.DecimalType; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.LogicalTypeFamily; +import org.apache.flink.table.types.logical.LogicalTypeRoot; + +import static org.apache.flink.table.planner.codegen.CodeGenUtils.primitiveLiteralForType; +import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.DECIMAL_ZERO; +import static org.apache.flink.table.planner.codegen.calls.BuiltInMethods.INTEGRAL_TO_DECIMAL; +import static org.apache.flink.table.planner.functions.casting.CastRuleUtils.staticCall; +import static org.apache.flink.table.planner.functions.casting.CastRuleUtils.ternaryOperator; + +/** {@link LogicalTypeRoot#BOOLEAN} to {@link LogicalTypeFamily#NUMERIC} conversions. */ +public class BooleanToNumericCastRule + extends AbstractExpressionCodeGeneratorCastRule<Boolean, Number> { + + static final BooleanToNumericCastRule INSTANCE = new BooleanToNumericCastRule(); + + private BooleanToNumericCastRule() { + super( + CastRulePredicate.builder() + .input(LogicalTypeRoot.BOOLEAN) + .target(LogicalTypeFamily.NUMERIC) + .build()); + } + + @Override + public String generateExpression( + CodeGeneratorCastRule.Context context, + String inputTerm, + LogicalType inputLogicalType, + LogicalType targetLogicalType) { + return ternaryOperator( + inputTerm, trueValue(targetLogicalType), falseValue(targetLogicalType)); + } + + private String trueValue(LogicalType target) { + switch (target.getTypeRoot()) { + case DECIMAL: + DecimalType decimalType = (DecimalType) target; + return staticCall( + INTEGRAL_TO_DECIMAL(), + 1, + decimalType.getPrecision(), + decimalType.getScale()); + case TINYINT: + return primitiveLiteralForType((byte) 1); + case SMALLINT: + return primitiveLiteralForType((short) 1); + case INTEGER: + return primitiveLiteralForType(1); + case BIGINT: + return primitiveLiteralForType(1L); + case FLOAT: + return primitiveLiteralForType(1f); + case DOUBLE: + return primitiveLiteralForType(1d); + } + throw new IllegalArgumentException("This is a bug. Please file an issue."); Review comment: nit, don't have to change: It's more of personal taste to use default statement to throw the exception, also below, but it's up to you. ########## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala ########## @@ -1096,29 +1096,6 @@ object ScalarOperatorGens { operandTerm => s"$operandTerm.toBytes($serTerm)" } - // Note: SQL2003 $6.12 - casting is not allowed between boolean and numeric types. Review comment: I would actually move it maybe to `LogicalTypeCasts`? So that we know that we chose to implement them instead of the SQL spec? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
