[ 
https://issues.apache.org/jira/browse/FLINK-25111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451687#comment-17451687
 ] 

Marios Trivyzas commented on FLINK-25111:
-----------------------------------------

By introducing this config option, it means that we'd have to duplicate tests 
for various cases to validate, the casting operation with and without legacy 
behaviour enabled.

I'd suggest to do that only in the unit test class: *CastRulesTest* and keep 
testing only the new behaviour in the IT tests (e.g. {*}CastFunctionITCase{*}), 
otherwise we'd make those IT tests more complex and more slow.

 

[~tiwalter] [~slinkydeveloper] [~jark] what do you think?

> Introduce config option to keep previous CAST behaviour
> -------------------------------------------------------
>
>                 Key: FLINK-25111
>                 URL: https://issues.apache.org/jira/browse/FLINK-25111
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table SQL / API, Table SQL / Planner
>            Reporter: Marios Trivyzas
>            Assignee: Marios Trivyzas
>            Priority: Major
>
> Introduce a new config option which will allow the users to experience the 
> previous behaviour of the `CAST` without any of the fixes/changes, and most 
> importantly, when casting fails, *null* will still be returned instead of 
> throwing an error, and requiring use of *TRY_CAST* to be able to return a 
> default value.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to